Return-Path: 
 <issues-return-44082-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B108218B4F
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Wed, 10 Feb 2016 14:09:21 +0000 (UTC)
Received: (qmail 36705 invoked by uid 500); 10 Feb 2016 14:09:21 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 36662 invoked by uid 500); 10 Feb 2016 14:09:21 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 36640 invoked by uid 99); 10 Feb 2016 14:09:21 -0000
Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2016 14:09:21 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org)
 with ESMTP id 0951CC0F92
	for <issues@flink.apache.org>; Wed, 10 Feb 2016 14:09:21 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -4.262
X-Spam-Level: 
X-Spam-Status: No, score=-4.262 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-0.242] autolearn=disabled
Received: from mx1-us-west.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new,
 port 10024)
	with ESMTP id cQn-wrf67Pvl for <issues@flink.apache.org>;
	Wed, 10 Feb 2016 14:09:19 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with
 SMTP id 0531220507
	for <issues@flink.incubator.apache.org>;
 Wed, 10 Feb 2016 14:09:19 +0000 (UTC)
Received: (qmail 34976 invoked by uid 99); 10 Feb 2016 14:09:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2016 14:09:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id C6569E020E; Wed, 10 Feb 2016 14:09:18 +0000 (UTC)
From: ggevay <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1517-flink@git.apache.org>
In-Reply-To: <git-pr-1517-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based
 combiner...
Content-Type: text/plain
Message-Id: <20160210140918.C6569E020E@git1-us-west.apache.org>
Date: Wed, 10 Feb 2016 14:09:18 +0000 (UTC)

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52460684
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java ---
    @@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayList<MemorySegment> segments, int segmentSize)
     	{
     		this(segments, segmentSize, segmentSize);
     	}
    -	
    +
    +	/**
    +	 * Warning: setReadPosition has to be called before reading.
    +	 */
     	public RandomAccessInputView(ArrayList<MemorySegment> segments, int segmentSize, int limitInLastSegment) {
    --- End diff --
    
    ok, will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---