Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C67F1847C for ; Fri, 5 Feb 2016 10:00:35 +0000 (UTC) Received: (qmail 30263 invoked by uid 500); 5 Feb 2016 10:00:25 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 30213 invoked by uid 500); 5 Feb 2016 10:00:25 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 30204 invoked by uid 99); 5 Feb 2016 10:00:25 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 10:00:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 33DD31A06B1 for ; Fri, 5 Feb 2016 10:00:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.449 X-Spam-Level: X-Spam-Status: No, score=-4.449 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.429] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8OFHBpiS13w2 for ; Fri, 5 Feb 2016 10:00:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id E433146475 for ; Fri, 5 Feb 2016 10:00:20 +0000 (UTC) Received: (qmail 30150 invoked by uid 99); 5 Feb 2016 10:00:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2016 10:00:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5894FDFF96; Fri, 5 Feb 2016 10:00:20 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT... Content-Type: text/plain Message-Id: <20160205100020.5894FDFF96@git1-us-west.apache.org> Date: Fri, 5 Feb 2016 10:00:20 +0000 (UTC) Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1581#issuecomment-180279675 Hi Stefano, thanks for the update! - you are right, it is good practice to not squash commits the address PR feedback. That make following the changes much easier. These commits will be squashed before merging to the master branch. - I am not sure if we are talking about the same thing. Robert suggested to move the code for reading inputs into the main method for examples that have only a single input such as TwitterStream or WordCount. This is the point we discussed before. Usually, there is only one parameter to check, i.e., whether an input path was provided or not. We do not need to move that into a `checkParameters` method, IMO. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---