flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3536) Make clearer distinction between event time and processing time
Date Mon, 29 Feb 2016 18:19:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172290#comment-15172290

ASF GitHub Bot commented on FLINK-3536:

Github user rmetzger commented on the pull request:

    Would you like to make this part of the 1.0.0 RC3?

> Make clearer distinction between event time and processing time
> ---------------------------------------------------------------
>                 Key: FLINK-3536
>                 URL: https://issues.apache.org/jira/browse/FLINK-3536
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Till Rohrmann
>            Assignee: Aljoscha Krettek
>            Priority: Minor
> If you define your own windows it is easy to mix up the time characteristic with the
wrong set of predefined {{WindowAssigners}}. You cannot use processing time with a {{TumblingTimeWindows}}
window assigner, for example.
> Neither from the name of {{TumblingTimeWindows}} nor from the JavaDocs it is clearly
obvious that this {{WindowAssigner}} can only be used with event time. I think it would be
better to rename the event time window assigner to something like {{TumblingEventTimeWindows}}.
Additionally, we could extend the JavaDocs a bit, since not everyone knows that "based on
the timestamps" means based on event time.

This message was sent by Atlassian JIRA

View raw message