flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3521) Make Iterable part of method signature for WindowFunction
Date Fri, 26 Feb 2016 20:19:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169723#comment-15169723
] 

ASF GitHub Bot commented on FLINK-3521:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1723#issuecomment-189464956
  
    I think (2) can be done easier if the operator creation code goes into something more
generic, but that is not that urgent.


> Make Iterable part of method signature for WindowFunction
> ---------------------------------------------------------
>
>                 Key: FLINK-3521
>                 URL: https://issues.apache.org/jira/browse/FLINK-3521
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>
> After discussion with [~StephanEwen],[~rmetzger], [~fhueske] it was decided that the
signature of WindowFunction should be changed.
> Right now, the signature is {{WindowFunction<IN, OUT, KEY, WINDOW>}}. With the
decision of whether the input is an {{Iterable}} nor not residing in the signature of the
method on {{WindowedStream}}, for example:
>  - {{WindowedStream.apply(WindowFunction<Iterable<IN>>, OUT, KEY, WINDOW>}}
>  - {{WindowedStream.apply(ReduceFunction, WindowFunction<IN, OUT, KEY, WINDOW>}}
> The {{Iterable<>}} should be moved into the signature of the {{apply}} method,
so that it is:
> {{void apply(KEY key, W window, Iterable<IN> input, Collector<OUT> out)}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message