flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3486) Use Project to rename all record fields would fail following Project.
Date Mon, 29 Feb 2016 16:01:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172050#comment-15172050
] 

ASF GitHub Bot commented on FLINK-3486:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1738#discussion_r54430318
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
    @@ -98,7 +100,19 @@ class Table(
           .map(toRexNode(_, relBuilder))
     
         relBuilder.project(exprs.toIterable.asJava)
    -    new Table(relBuilder.build(), relBuilder)
    +    var projected = relBuilder.build()
    +
    +    if(relNode == projected) {
    +      // Calcite's RelBuilder does not translate identity projects even if they rename
fields.
    +      //   Add a projection ourselves (will be automatically removed by translation rules).
    +      val names = exprs.map(_.asInstanceOf[RexCall].getOperands.get(1)
    --- End diff --
    
    This cast to `RexCall` seems to cause several tests to fail.


> Use Project to rename all record fields would fail following Project.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-3486
>                 URL: https://issues.apache.org/jira/browse/FLINK-3486
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API
>            Reporter: Chengxiang Li
>            Assignee: Fabian Hueske
>
> {noformat} val t = CollectionDataSets.get3TupleDataSet(env).toTable
>       .select('_1 as 'a, '_2 as 'b, '_3 as 'c)
>       .select('a, 'b)
> {noformat}
> would throw exception like:
> {noformat}
> java.lang.IllegalArgumentException: field [a] not found; input fields are: [_1, _2, _3]
> 	at org.apache.calcite.tools.RelBuilder.field(RelBuilder.java:290)
> 	at org.apache.calcite.tools.RelBuilder.field(RelBuilder.java:275)
> 	at org.apache.flink.api.table.plan.RexNodeTranslator$.toRexNode(RexNodeTranslator.scala:80)
> 	at org.apache.flink.api.table.Table$$anonfun$5.apply(table.scala:98)
> 	at org.apache.flink.api.table.Table$$anonfun$5.apply(table.scala:98) {noformat}
> new alias names are lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message