flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3443) JobManager cancel and clear everything fails jobs instead of cancelling
Date Fri, 26 Feb 2016 16:22:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169252#comment-15169252

ASF GitHub Bot commented on FLINK-3443:

GitHub user uce opened a pull request:


    [FLINK-3443] [runtime] Prevent cancelled jobs from restarting

    This is one part of #1669 for which we have consensus I think. It would be good to have
it in the next RC. @rmetzger ran into this issue. It showed up as a job not cancelling, because
a failure was overwriting the cancellation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink cancel-overwrites-fail

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1726
commit 1c11436f85697333b900830d4cb7e74cc1059f48
Author: Ufuk Celebi <uce@apache.org>
Date:   2016-02-26T16:12:05Z

    [FLINK-3443] [runtime] Prevent cancelled jobs from restarting


> JobManager cancel and clear everything fails jobs instead of cancelling
> -----------------------------------------------------------------------
>                 Key: FLINK-3443
>                 URL: https://issues.apache.org/jira/browse/FLINK-3443
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
> When the job manager is shut down, it calls {{cancelAndClearEverything}}. This method
does not {{cancel}} the {{ExecutionGraph}} instances, but {{fail}}s them, which can lead to
{{ExecutionGraph}} restart.
> I've noticed this in tests, where old graph got into a loop of restarts.
> What I don't understand is why the futures etc. are not cancelled when the executor service
is shut down.

This message was sent by Atlassian JIRA

View raw message