flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3379) Refactor TimestampExtractor
Date Wed, 17 Feb 2016 09:35:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15150183#comment-15150183
] 

ASF GitHub Bot commented on FLINK-3379:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1646#issuecomment-185116590
  
    I found a minor test flakeyness. Fixing that and merging this...


> Refactor TimestampExtractor
> ---------------------------
>
>                 Key: FLINK-3379
>                 URL: https://issues.apache.org/jira/browse/FLINK-3379
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 0.10.1
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Critical
>             Fix For: 1.0.0
>
>
> Based on a lot of user feedback, the current {{TimestampExtractor}} seems very confusing.
It implements simultaneously two modes of generating watermarks:
>   - Each record that passes through can decide to cause a watermark.
>   - The timestamp extractor can define a certain watermark timestamp which is periodically
picked up by the system and triggers a watermark (if larger than the previous watermark).
> Figuring out how these modes interplay, and how to define the methods to only use one
mode has been quite an obstacle for several users. We should break this class into two different
classes, one per mode of generating watermarks, to make it easier to understand.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message