flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3357) Drop JobId.toShortString()
Date Mon, 08 Feb 2016 15:51:39 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137103#comment-15137103
] 

ASF GitHub Bot commented on FLINK-3357:
---------------------------------------

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1601#issuecomment-181436492
  
    In RocksDB it should work. It is just local filesystem paths and FileSystem paths that
are affected by this.


> Drop JobId.toShortString()
> --------------------------
>
>                 Key: FLINK-3357
>                 URL: https://issues.apache.org/jira/browse/FLINK-3357
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.10.1
>            Reporter: Stephan Ewen
>            Assignee: Ufuk Celebi
>             Fix For: 1.0.0
>
>
> There are several places that use JobId.toShortString() instead of the full JobID, for
unique directories, etc.
> I think we should drop that method.
>   - If the short String representation (8 bytes) is statistically "unique enough", then
it is wrong in the first place that the unique IDs have 16 bytes
>   - If 16 bytes were chosen with a purpose, then using the short string representation
in paths, etc, is clearly violating the guarantees the IDs try to give,
> For purely informational logging, it may be a nice util, bit it seems to encourage wrong
use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message