flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefano Baghino (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLINK-3353) CSV-related tests may fail depending on locale
Date Sat, 06 Feb 2016 21:56:39 GMT
Stefano Baghino created FLINK-3353:

             Summary: CSV-related tests may fail depending on locale
                 Key: FLINK-3353
                 URL: https://issues.apache.org/jira/browse/FLINK-3353
             Project: Flink
          Issue Type: Bug
          Components: Tests
    Affects Versions: 1.0.0
            Reporter: Stefano Baghino
            Assignee: Stefano Baghino
            Priority: Trivial
             Fix For: 1.0.0

As I've been running some tests, three suites ({{KMeansWithBroadcastSetITCase.java}}, {{ScalaCsvReaderWithPOJOITCase.scala}}
and {{CsvReaderITCase.java}}) kept failing locally because the expected results (string literals)
were matched against an object rendered as a string using the {{String.format}} method, a
method whose result depends on the default Locale; as my Locale (Italian) renders doubles
with a comma instead of a dot as the decimal separator, the representation of doubles diverged
from the expected one, thus making my tests fail, despite the results actually being correct.

As the result is hard-coded, it makes sense to explicitly use the US locale to represent those
object. I'll open a PR with my solution ASAP.

This message was sent by Atlassian JIRA

View raw message