flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3296) DataStream.write*() methods are not flushing properly
Date Fri, 12 Feb 2016 17:07:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144868#comment-15144868
] 

ASF GitHub Bot commented on FLINK-3296:
---------------------------------------

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1563#issuecomment-183414977
  
    I think the `writeOutputFormat` method name could be misleading. To me it implies writing
the `OutputFormat` not writing something by using the `OutputFormat`.


> DataStream.write*() methods are not flushing properly
> -----------------------------------------------------
>
>                 Key: FLINK-3296
>                 URL: https://issues.apache.org/jira/browse/FLINK-3296
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Critical
>
> The DataStream.write() methods rely on the {{FileSinkFunctionByMillis}} class, which
has a logic for flushing records, even though the underlying stream is never flushed. This
is misleading for users as files are not written as they would expect it.
> The code was initial written with FileOutputFormats in mind, but the types were not set
correctly. This PR opened the write() method to any output format: https://github.com/apache/flink/pull/706/files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message