flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3277) Use Value types in Gelly API
Date Thu, 18 Feb 2016 19:00:20 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152855#comment-15152855
] 

ASF GitHub Bot commented on FLINK-3277:
---------------------------------------

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/1671

    [FLINK-3277] Use Value types in Gelly API

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 3277_use_value_types_in_gelly_api

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1671.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1671
    
----
commit 3770468f7a9b9ea2895495e522d0d421e1f16c08
Author: Greg Hogan <code@greghogan.com>
Date:   2016-02-18T15:40:39Z

    [FLINK-3277] Use Value types in Gelly API

----


> Use Value types in Gelly API
> ----------------------------
>
>                 Key: FLINK-3277
>                 URL: https://issues.apache.org/jira/browse/FLINK-3277
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> This would be a breaking change so the discussion needs to happen before the 1.0.0 release.
> I think it would benefit Flink to use {{Value}} types wherever possible. The {{Graph}}
functions {{inDegrees}}, {{outDegrees}}, and {{getDegrees}} each return {{DataSet<Tuple2<K,
Long>>}}. Using {{Long}} creates a new heap object for every serialization and deserialization.
The mutable {{Value}} types do not suffer from this issue when object reuse is enabled.
> I lean towards a preference for conciseness in documentation and performance in examples
and APIs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message