flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3277) Use Value types in Gelly API
Date Thu, 25 Feb 2016 18:24:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167586#comment-15167586

ASF GitHub Bot commented on FLINK-3277:

Github user StephanEwen commented on the pull request:

    Thanks for checking this out.
    Do you have an estimate of how this affects Gelly performance for some algorithms? How
much does this improve the performance?

> Use Value types in Gelly API
> ----------------------------
>                 Key: FLINK-3277
>                 URL: https://issues.apache.org/jira/browse/FLINK-3277
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 1.0.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
> This would be a breaking change so the discussion needs to happen before the 1.0.0 release.
> I think it would benefit Flink to use {{Value}} types wherever possible. The {{Graph}}
functions {{inDegrees}}, {{outDegrees}}, and {{getDegrees}} each return {{DataSet<Tuple2<K,
Long>>}}. Using {{Long}} creates a new heap object for every serialization and deserialization.
The mutable {{Value}} types do not suffer from this issue when object reuse is enabled.
> I lean towards a preference for conciseness in documentation and performance in examples
and APIs.

This message was sent by Atlassian JIRA

View raw message