flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException
Date Mon, 01 Feb 2016 15:37:39 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126403#comment-15126403
] 

ASF GitHub Bot commented on FLINK-3265:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1569#discussion_r51432473
  
    --- Diff: flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
---
    @@ -219,7 +140,9 @@ public void testCheckpointing() throws Exception {
     			}
     
     			// check if the messages are being acknowledged and the transaction comitted
    -			source.notifyCheckpointComplete(snapshotId);
    +			synchronized (DummySourceContext.lock) {
    --- End diff --
    
    So this is the fix of the actual issue, right?


> RabbitMQ Source not threadsafe: ConcurrentModificationException
> ---------------------------------------------------------------
>
>                 Key: FLINK-3265
>                 URL: https://issues.apache.org/jira/browse/FLINK-3265
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>            Reporter: Robert Metzger
>            Assignee: Maximilian Michels
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.0.0
>
>
> {code}
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest
> Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.454 sec <<<
FAILURE! - in org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest
> testCheckpointing(org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest)  Time
elapsed: 0.902 sec  <<< ERROR!
> java.util.ConcurrentModificationException: null
> 	at java.util.HashMap$HashIterator.remove(HashMap.java:1443)
> 	at java.util.AbstractSet.removeAll(AbstractSet.java:178)
> 	at org.apache.flink.streaming.api.functions.source.MessageAcknowledgingSourceBase.notifyCheckpointComplete(MessageAcknowledgingSourceBase.java:198)
> 	at org.apache.flink.streaming.connectors.rabbitmq.RMQSourceTest.testCheckpointing(RMQSourceTest.java:144)
> Results :
> Tests in error: 
>   RMQSourceTest.testCheckpointing:144 » ConcurrentModification
> {code}
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/103452897/log.txt



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message