flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2237) Add hash-based Aggregation
Date Wed, 10 Feb 2016 17:04:18 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141183#comment-15141183
] 

ASF GitHub Bot commented on FLINK-2237:
---------------------------------------

Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52488669
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
    @@ -100,340 +101,371 @@
     	@Test
     	public void testDifferentProbers() {
     		final int NUM_MEM_PAGES = 32 * NUM_PAIRS / PAGE_SIZE;
    -		
    -		AbstractMutableHashTable<IntPair> table = new CompactingHashTable<IntPair>(serializer,
comparator, getMemory(NUM_MEM_PAGES, PAGE_SIZE));
    -		
    +		testDifferentProbersCore(new CompactingHashTable<>(serializer, comparator, getMemory(NUM_MEM_PAGES,
PAGE_SIZE)), NUM_MEM_PAGES);
    --- End diff --
    
    OK, I'll split the top-level methods into two methods, and move these to different classes.
However, the core of the tests can remain shared, right?
    
    For example, I would split `testBuildAndRetrieve` to two methods, and move these to different
classes, but both of them would still call the same `testBuildAndRetrieveCore`.


> Add hash-based Aggregation
> --------------------------
>
>                 Key: FLINK-2237
>                 URL: https://issues.apache.org/jira/browse/FLINK-2237
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Rafiullah Momand
>            Assignee: Gabor Gevay
>            Priority: Minor
>
> Aggregation functions at the moment are implemented in a sort-based way.
> How can we implement hash based Aggregation for Flink?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message