flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3486] [tableAPI] Fix broken renaming of...
Date Mon, 29 Feb 2016 16:00:57 GMT
Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1738#discussion_r54430318
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
    @@ -98,7 +100,19 @@ class Table(
           .map(toRexNode(_, relBuilder))
     
         relBuilder.project(exprs.toIterable.asJava)
    -    new Table(relBuilder.build(), relBuilder)
    +    var projected = relBuilder.build()
    +
    +    if(relNode == projected) {
    +      // Calcite's RelBuilder does not translate identity projects even if they rename
fields.
    +      //   Add a projection ourselves (will be automatically removed by translation rules).
    +      val names = exprs.map(_.asInstanceOf[RexCall].getOperands.get(1)
    --- End diff --
    
    This cast to `RexCall` seems to cause several tests to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message