flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1159] Case style anonymous functions no...
Date Wed, 24 Feb 2016 16:01:56 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1704#issuecomment-188320230
  
    How do you want to do the implicit conversion if you return a `DataSet[T]`. If it makes
the code more readable, then I think it's a good idea :-)
    
    We should have a test, which makes sure that the implicit conversion works when you import
the corresponding package. That should be enough.
    
    I think we could add the documentation to the streaming guide. We could add a new page
with the methods and link it from the scala tab of [DataStream Transformations](https://ci.apache.org/projects/flink/flink-docs-master/apis/streaming/index.html#datastream-transformations)
in the streaming guide.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message