flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3226] Translation of scalar function su...
Date Wed, 24 Feb 2016 08:04:43 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1679#discussion_r53905238
  
    --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/table/test/StringExpressionsITCase.java
---
    @@ -40,46 +40,6 @@ public StringExpressionsITCase(TestExecutionMode mode) {
     		super(mode);
     	}
     
    -	@Test(expected = CodeGenException.class)
    --- End diff --
    
    No, the `ScalarFunctionsTest` does not test end-to-end. I don't think this is necessary
for scalar functions, because they don't affect optimization/plan translation. When we will
have more functions (e.g. 40 of them), we would have 40 end-to-end tests just implementing
a MapFunction and evaluating an expression. That's why I implemented the `ExpressionEvaluator`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message