flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3179 Combiner is not injected if Reduce ...
Date Wed, 17 Feb 2016 11:47:46 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/ReduceProperties.java
    @@ -59,37 +65,69 @@ public DriverStrategy getStrategy() {
     	public SingleInputPlanNode instantiate(Channel in, SingleInputNode node) {
     		if (in.getShipStrategy() == ShipStrategyType.FORWARD ||
    -				(node.getBroadcastConnections() != null && !node.getBroadcastConnections().isEmpty()))
    +			(node.getBroadcastConnections() != null && !node.getBroadcastConnections().isEmpty()))
    +			// adjust a sort (changes grouping, so it must be for this driver to combining sort
    +			if(in.getSource().getOptimizerNode() instanceof PartitionNode) {
    --- End diff --
    Please refactor the code of this branch into a method called `injectCombinerBeforePartitioner()`.
Some of the comments in the other class apply here as well.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message