flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2111] Add "stop" signal to cleanly shut...
Date Thu, 11 Feb 2016 13:19:19 GMT
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/750#issuecomment-182859453
  
    Really good work @mjsax.
    
    I had a couple of minor inline comments with respect to the latest commit and some with
respect to the overall changes (especially concerning the `decorateMessage` method).
    
    Why have you changed the `vendor.js` and the `index.js` file? I thought that these files
should stay unchanged.
    
    I was wondering whether we shouldn't make the `StoppableSourceStreamTask` and the `StoppableStreamSource`
type safe, e.g. enforcing that the `StreamSource` and the `SourceFunction` are actually stoppable.
Currently, this is not properly checked/enforced. This should be done by the compiler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message