flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...
Date Wed, 10 Feb 2016 14:12:02 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52461048
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/MemoryHashTableTest.java
---
    @@ -100,340 +101,371 @@
     	@Test
     	public void testDifferentProbers() {
     		final int NUM_MEM_PAGES = 32 * NUM_PAIRS / PAGE_SIZE;
    -		
    -		AbstractMutableHashTable<IntPair> table = new CompactingHashTable<IntPair>(serializer,
comparator, getMemory(NUM_MEM_PAGES, PAGE_SIZE));
    -		
    +		testDifferentProbersCore(new CompactingHashTable<>(serializer, comparator, getMemory(NUM_MEM_PAGES,
PAGE_SIZE)), NUM_MEM_PAGES);
    --- End diff --
    
    Tests for different tables should be put into different methods or even better into different
test classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message