flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggevay <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...
Date Wed, 10 Feb 2016 14:09:18 GMT
Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52460684
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/RandomAccessInputView.java
---
    @@ -45,9 +45,12 @@ public RandomAccessInputView(ArrayList<MemorySegment> segments,
int segmentSize)
     	{
     		this(segments, segmentSize, segmentSize);
     	}
    -	
    +
    +	/**
    +	 * Warning: setReadPosition has to be called before reading.
    +	 */
     	public RandomAccessInputView(ArrayList<MemorySegment> segments, int segmentSize,
int limitInLastSegment) {
    --- End diff --
    
    ok, will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message