flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...
Date Wed, 10 Feb 2016 13:55:03 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1517#discussion_r52458969
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/operators/base/ReduceOperatorBase.java
---
    @@ -52,6 +52,30 @@
      */
     public class ReduceOperatorBase<T, FT extends ReduceFunction<T>> extends
SingleInputOperator<T, T, FT> {
     
    +	/**
    +	 * An enumeration of hints, optionally usable to tell the system exactly how to execute
the reduce.
    +	 */
    +	public enum ReduceHint {
    --- End diff --
    
    Should be renamed to `CombineHint` and all corresponding methods and member variables
as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message