flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3260] [runtime] Enforce terminal state ...
Date Wed, 10 Feb 2016 09:20:11 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1613#discussion_r52432150
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
    @@ -107,7 +108,7 @@
     	private static final AtomicReferenceFieldUpdater<Execution, ExecutionState> STATE_UPDATER
=
     			AtomicReferenceFieldUpdater.newUpdater(Execution.class, ExecutionState.class, "state");
     	
    -	private static final Logger LOG = ExecutionGraph.LOG;
    +	private static final Logger LOG = LoggerFactory.getLogger(Execution.class);
    --- End diff --
    
    I have to admit that it confused me when parsing the log, because state changes of the
`Execution` were reported from the `ExecutionGraph` logger. When I tried to pinpoint the exact
location of the logging statement, I searched for the logging string in the `ExecutionGraph`
but couldn't find it. But I also see your point. If you want to, I can revert the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message