flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...
Date Mon, 08 Feb 2016 15:49:58 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1513#discussion_r52185124
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
    @@ -163,7 +166,11 @@ public KeyedStream(DataStream<T> dataStream, KeySelector<T,
KEY> keySelector, Ty
     	 * @param size The size of the window.
     	 */
     	public WindowedStream<T, KEY, TimeWindow> timeWindow(AbstractTime size) {
    -		return window(TumblingTimeWindows.of(size));
    +		if (environment.getStreamTimeCharacteristic() == TimeCharacteristic.PROCESSING_TIME)
{
    --- End diff --
    
    I'm not sure how the rest of the DataStream API is behaving, but I though that it doesn't
matter when the environment settings (for example parallelism) are set.
    In this case, users have to set the `TimeCharacteristic` before using operators.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message