flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...
Date Fri, 05 Feb 2016 10:00:20 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1581#issuecomment-180279675
  
    Hi Stefano, thanks for the update!
    
    - you are right, it is good practice to not squash commits the address PR feedback. That
make following the changes much easier. These commits will be squashed before merging to the
master branch.
    - I am not sure if we are talking about the same thing. Robert suggested to move the code
for reading inputs into the main method for examples that have only a single input such as
TwitterStream or WordCount. This is the point we discussed before. Usually, there is only
one parameter to check, i.e., whether an input path was provided or not. We do not need to
move that into a `checkParameters` method, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message