Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Thu, 14 Jan 2016 19:05:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12915175.1448212615000.112924.1452798339954@Atlassian.JIRA>
In-Reply-To: <JIRA.12915175.1448212615000@Atlassian.JIRA>
References: <JIRA.12915175.1448212615000@Atlassian.JIRA>
 <JIRA.12915175.1448212615906@arcas>
Subject: [jira] [Commented] (FLINK-3058) Add Kafka consumer for new 0.9.0.0
 Kafka API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLINK-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098653#comment-15098653 ] 

ASF GitHub Bot commented on FLINK-3058:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1489#issuecomment-171741270
  
    This PR changes the name of the KafkaConsumer classes. Both of them are now called `FlinkKafkaConsumer` in the exact same namespace, and only differ in their Maven project.
    
    I think that is dangerous (classes with exact same qualified name). We have seem many cases where people work with unclean dependencies, which would result in a name clash if both dependencies are accidentally included.
    The end result being that the wrong class is used, the connector does not work, and is non trivial to recognize that for users.
    
    I would vote for the following:
      - Put a qualifier either in the class name or the package: `.connectors.kafka.FlinkKafkaConsumer08` or `.connectors.kafka08.FlinkKafkaConsumer`
      - Keep the current 0.8 classes for compatibility and deprecate them.


> Add Kafka consumer for new 0.9.0.0 Kafka API
> --------------------------------------------
>
>                 Key: FLINK-3058
>                 URL: https://issues.apache.org/jira/browse/FLINK-3058
>             Project: Flink
>          Issue Type: New Feature
>          Components: Kafka Connector
>    Affects Versions: 1.0.0
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> The Apache Kafka project is about to release a new consumer API . They also changed their internal protocol so Kafka 0.9.0.0 users will need an updated consumer from Flink.
> Also, I would like to let Flink be among the first stream processors supporting Kafka 0.9.0.0.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)