Return-Path: 
 <issues-return-40921-apmail-flink-issues-archive=flink.apache.org@flink.apache.org>
X-Original-To: apmail-flink-issues-archive@minotaur.apache.org
Delivered-To: apmail-flink-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2CF3718E8A
	for <apmail-flink-issues-archive@minotaur.apache.org>;
 Tue, 12 Jan 2016 14:57:40 +0000 (UTC)
Received: (qmail 57330 invoked by uid 500); 12 Jan 2016 14:57:40 -0000
Delivered-To: apmail-flink-issues-archive@flink.apache.org
Received: (qmail 57283 invoked by uid 500); 12 Jan 2016 14:57:40 -0000
Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@flink.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@flink.apache.org>
List-Post: <mailto:issues@flink.apache.org>
List-Id: <issues.flink.apache.org>
Reply-To: dev@flink.apache.org
Delivered-To: mailing list issues@flink.apache.org
Received: (qmail 57269 invoked by uid 99); 12 Jan 2016 14:57:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jan 2016 14:57:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id C423F2C14F0
	for <issues@flink.apache.org>; Tue, 12 Jan 2016 14:57:39 +0000 (UTC)
Date: Tue, 12 Jan 2016 14:57:39 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12833719.1432890296000.85397.1452610659799@Atlassian.JIRA>
In-Reply-To: <JIRA.12833719.1432890296000@Atlassian.JIRA>
References: <JIRA.12833719.1432890296000@Atlassian.JIRA>
 <JIRA.12833719.1432890296612@arcas>
Subject: [jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly
 shutdown streaming jobs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094011#comment-15094011 ] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r49463485
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java ---
    @@ -402,21 +405,52 @@ public void onComplete(Throwable failure, Object success) throws Throwable {
     		}
     	}
     
    +	public void stop() {
    +		// sends stop RPC call
    +
    +		final SimpleSlot slot = this.assignedResource;
    +
    +		if (slot != null) {
    +			final ActorGateway gateway = slot.getInstance().getActorGateway();
    +
    +			Future<Object> stopResult = gateway.retry(
    +				new StopTask(attemptId),
    +				NUM_STOP_CALL_TRIES,
    +				timeout,
    +				executionContext);
    +
    +			stopResult.onComplete(new OnComplete<Object>() {
    +				@Override
    +				public void onComplete(Throwable failure, Object success) throws Throwable {
    +					if (failure != null) {
    +						fail(new Exception("Task could not be stopped.", failure));
    +					} else {
    +						TaskOperationResult result = (TaskOperationResult) success;
    +						if (!result.success()) {
    --- End diff --
    
    Does this condition really say that the task could not be found? In the current implementation a `TaskOperationResult` message with `success == false` is also returned if an exception is thrown in `Task.stop`.


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, Streaming, TaskManager, Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is a "hard" stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks such that the sources can stop emitting data and shutdown cleanly, resulting in a clean shutdown of the whole streaming job.
> This feature is a pre-requirment for https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)