flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Metzger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3210) Unnecessary call to deserializer#deserialize() in LegacyFetcher#SimpleConsumerThread#run()
Date Fri, 08 Jan 2016 17:29:39 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089566#comment-15089566
] 

Robert Metzger commented on FLINK-3210:
---------------------------------------

I think this issue is invalid. A null value indicates a deleted Kafka message. The key can
still contain something, and somebody explicitly opened a JIRA for this feature.

> Unnecessary call to deserializer#deserialize() in LegacyFetcher#SimpleConsumerThread#run()
> ------------------------------------------------------------------------------------------
>
>                 Key: FLINK-3210
>                 URL: https://issues.apache.org/jira/browse/FLINK-3210
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>                 byte[] valueBytes;
>                 if (payload == null) {
>                   deletedMessages++;
>                   valueBytes = null;
>                 } else {
> ...
>                 final T value = deserializer.deserialize(keyBytes, valueBytes, fp.topic,
offset);
> {code}
> When valueBytes is null, there is no need to call deserializer#deserialize()



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message