flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3197) InputStream not closed in BinaryInputFormat#createStatistics
Date Fri, 08 Jan 2016 07:28:39 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088831#comment-15088831
] 

ASF GitHub Bot commented on FLINK-3197:
---------------------------------------

GitHub user ajaybhat opened a pull request:

    https://github.com/apache/flink/pull/1494

    FLINK-3197: InputStream not closed in BinaryInputFormat#createStatistics

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajaybhat/flink input_stream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1494.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1494
    
----
commit 4669df94ad715eb76ab8ead7898e86c67596ee85
Author: Ajay Bhat <a.ajay.bhat@gmail.com>
Date:   2016-01-08T07:01:02Z

    FLINK-3197
    InputStream not closed in BinaryInputFormat#createStatistics

----


> InputStream not closed in BinaryInputFormat#createStatistics
> ------------------------------------------------------------
>
>                 Key: FLINK-3197
>                 URL: https://issues.apache.org/jira/browse/FLINK-3197
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>       FSDataInputStream fdis = file.getPath().getFileSystem().open(file.getPath(), blockInfo.getInfoSize());
>       fdis.seek(file.getLen() - blockInfo.getInfoSize());
>       blockInfo.read(new DataInputViewStreamWrapper(fdis));
>       totalCount += blockInfo.getAccumulatedRecordCount();
> {code}
> fdis / wrapper should be closed upon leaving the method



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message