flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3178) Make Closing Behavior of Window Operators Configurable
Date Mon, 25 Jan 2016 16:09:39 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115455#comment-15115455

ASF GitHub Bot commented on FLINK-3178:

Github user aljoscha commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java
    @@ -214,6 +214,7 @@ public void complexIntegrationTest2() throws Exception {
    +	@Ignore
    --- End diff --
    The test depended on the behavior that closing emits in-flight windows. Actually, the
window fires only once, and the result of this firing is even filtered by the filter. So the
count window is useless. I can also remove the test. (Or the complete suite of tests since
I mostly don't know what they are doing/testing.)

> Make Closing Behavior of Window Operators Configurable
> ------------------------------------------------------
>                 Key: FLINK-3178
>                 URL: https://issues.apache.org/jira/browse/FLINK-3178
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 1.0.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
> Right now, all window operators emit (incomplete) in-flight windows when they are closing
down. This happens for two reasons:
> 1. sources emit a final Long.MAX_VALUE watermark to flush out windows when they close.
> 2. window operators emit in-flight windows in their close() method
> For some users this might not be the desired behavior so we should either change it or
make it configurable.

This message was sent by Atlassian JIRA

View raw message