flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3292]Fix for Bug in flink-jdbc. Not all...
Date Wed, 27 Jan 2016 08:48:45 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1551#discussion_r50955346
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -92,6 +94,15 @@ public void open(InputSplit ignored) throws IOException {
     		}
     	}
     
    +	private Statement createStatement() throws SQLException {
    +		if(resultSetType == 0 || resultSetConcurrency == 0) {
    --- End diff --
    
    this line might lead to confusion when a user only sets either the type or concurrency.

    IMO we should check with && here, require the user to set both type and concurrency
at the same time, and throw a meaningful exception if only one these is 0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message