flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chiwanpark <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...
Date Thu, 21 Jan 2016 12:25:53 GMT
Github user chiwanpark commented on a diff in the pull request:

    --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala
    @@ -107,6 +107,11 @@ class MultipleLinearRegression extends Predictor[MultipleLinearRegression]
    +  def setOptimizationMethod(optimizationMethod: String): this.type = {
    --- End diff --
    @tillrohrmann How about creating a trait called `OptimizationMethod` which has a 'learningRate'
method and using a derived class as a parameter?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message