flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...
Date Thu, 21 Jan 2016 10:40:46 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1469#discussion_r50384749
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
    @@ -486,11 +518,43 @@ protected boolean processProbeIter() throws IOException{
     			}
     		}
     		// -------------- partition done ---------------
    -		
    +
     		return false;
     	}
     	
    +	protected boolean processUnmatchedBuildIter() throws IOException  {
    +		if (this.unmatchedBuildVisited) {
    +			return false;
    +		}
    +		
    +		this.probeMatchedPhase = false;
    +		UnmatchedBuildIterator<BT, PT> unmatchedBuildIter = new UnmatchedBuildIterator<>(this.buildSideSerializer,
this.numBuckets,
    +			this.bucketsPerSegmentBits, this.bucketsPerSegmentMask, this.buckets, this.partitionsBeingBuilt,
probedSet);
    +		this.unmatchedBuildIterator = unmatchedBuildIter;
    +		
    +		// There maybe none unmatched build element, so we add a verification here to make
sure we do not return (null, null) to user.
    +		if (unmatchedBuildIter.next() == null) {
    +			this.unmatchedBuildVisited = true;
    +			return false;
    +		}
    +		
    +		unmatchedBuildIter.back();
    +		
    +		// While visit the unmatched build elements, the probe element is null, and the unmatchedBuildIterator
    +		// would iterate all the unmatched build elements, so we return false during the second
calling of this method.
    +		if (!this.unmatchedBuildVisited) {
    --- End diff --
    
    But you leave the method in line 538 with `return false` and the check in line 526 prevents
that you get to line 545 if `unmatchedBuildVisited == true` again. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message