flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-2380: allow to specify the default files...
Date Wed, 20 Jan 2016 13:31:51 GMT
Github user uce commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
    @@ -303,6 +303,16 @@
     	// ------------------------ File System Behavior ------------------------
    +	 * Key to specify the default filesystem to be used by a job, e.g.
    +	 * <code>file:///</code> which is the default (see {@link ConfigConstants#DEFAULT_FILESYSTEM_SCHEME})
    --- End diff --
    Same questions as wth the docs. Why `file:///`? And I would remove the `HDFS deployment`
part at the end.
    Furthermore, I would add something alone the lines of `This scheme is used <b>ONLY</b>
if no other scheme is specified in the user-provided <code>URI</code>` to the
docs as well.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message