flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ChengXiangLi <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...
Date Wed, 20 Jan 2016 06:53:34 GMT
Github user ChengXiangLi commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1469#discussion_r50220144
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
---
    @@ -130,11 +130,11 @@ public void testSortBothMerge() {
     			
     			final UnilateralSortMerger<Tuple2<Integer, String>> sorter1 = new UnilateralSortMerger<>(
     					this.memoryManager, this.ioManager, input1, this.parentTask, this.serializer1, 
    -					this.comparator1.duplicate(), MEMORY_FOR_SORTER, 128, 0.8f, true);
    +					this.comparator1.duplicate(), (double)MEMORY_FOR_SORTER/MEMORY_SIZE, 128, 0.8f,
true);
    --- End diff --
    
    If does not cast to double, the result would 0.0 which is not the desired memory fraction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message