flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [Storm-Compatibility] Forward Storm Kryo regis...
Date Thu, 14 Jan 2016 21:17:39 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-contrib/flink-storm/src/main/java/org/apache/flink/storm/api/FlinkClient.java
    @@ -181,9 +188,11 @@ public void submitTopologyWithOpts(final String name, final String
     			throw new RuntimeException("Problem with jar file " + uploadedJarLocation, e);
    -		/* set storm configuration */
    -		if (this.conf != null) {
    -			topology.getExecutionEnvironment().getConfig().setGlobalJobParameters(new StormConfig(this.conf));
    +		try {
    +			FlinkClient.addStormConfigToTopology(topology, conf);
    +		} catch(ClassNotFoundException e) {
    +			LOG.error("Could not register class for Kryo serialization.", e);
    +			throw new InvalidTopologyException();
    --- End diff --
    Would be good to add the logged error message also to the exception. Gives more instant
feedback to the user what exactly went wrong.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message