flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...
Date Thu, 14 Jan 2016 14:04:06 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/HashVsSortMiniBenchmark.java
    @@ -184,7 +184,7 @@ public void testBuildFirst() {
     					new ReusingBuildFirstHashJoinIterator<>(
     						input1, input2, this.serializer1.getSerializer(), this.comparator1, 
     							this.serializer2.getSerializer(), this.comparator2, this.pairComparator11,
    -							this.memoryManager, this.ioManager, this.parentTask, MEMORY_SIZE, false, true);
    +							this.memoryManager, this.ioManager, this.parentTask, 1, false, false, true);
    --- End diff --
    Why did you set the memory to `1`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message