flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...
Date Wed, 13 Jan 2016 21:51:30 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1469#discussion_r49656327
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
    @@ -486,11 +518,43 @@ protected boolean processProbeIter() throws IOException{
     			}
     		}
     		// -------------- partition done ---------------
    -		
    +
     		return false;
     	}
     	
    +	protected boolean processUnmatchedBuildIter() throws IOException  {
    +		if (this.unmatchedBuildVisited) {
    +			return false;
    +		}
    +		
    +		this.probeMatchedPhase = false;
    +		UnmatchedBuildIterator<BT, PT> unmatchedBuildIter = new UnmatchedBuildIterator<>(this.buildSideSerializer,
this.numBuckets,
    +			this.bucketsPerSegmentBits, this.bucketsPerSegmentMask, this.buckets, this.partitionsBeingBuilt,
probedSet);
    +		this.unmatchedBuildIterator = unmatchedBuildIter;
    +		
    +		// There maybe none unmatched build element, so we add a verification here to make
sure we do not return (null, null) to user.
    +		if (unmatchedBuildIter.next() == null) {
    --- End diff --
    
    IMO, it would be nicer to implement a `hasNext()` method for `UnmatchedBuildIterator`
instead of calling `next()` and `back()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message