flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3140] NULL value data layout in Row Ser...
Date Tue, 12 Jan 2016 14:07:28 GMT
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1465#issuecomment-170921788
  
    The `NullAwareComparator` knows about the order of its wrapped comparator. So we can implement
the `getFlatComparators()` method of `NullAwareComparator`, call `getFlatComparators()` on
the wrapped comparator and wrap each returned comparator again in a `NullAwareComparator`
with the same order as the wrapping one. I think that should work, but maybe I am overlooking
something here...
    
    IMO, the problem with `isAscending()` is that it is only implemented for BasicTypes (Int,
String, etc.) but not for other atomic types such as generic or writable types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message