flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3140] NULL value data layout in Row Ser...
Date Tue, 12 Jan 2016 11:21:02 GMT
Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/typeinfo/NullAwareComparator.scala
    @@ -0,0 +1,186 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.table.typeinfo
    +import org.apache.flink.api.common.typeutils.TypeComparator
    +import org.apache.flink.core.memory.{MemorySegment, DataOutputView, DataInputView}
    + * Null-aware comparator that wraps a comparator which does not support null references.
    + */
    +class NullAwareComparator[T](
    +    val wrappedComparator: TypeComparator[T],
    --- End diff --
    Are you sure we want to limit rows to atomic types only?
    Why should the wrapping not work for composite types? If you have a look into my test
cases, I already test Tuples and Pojos successfully.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message