flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3174] Add merging WindowAssigner
Date Thu, 07 Jan 2016 13:59:14 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1460#discussion_r49074871
  
    --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperatorTest.java
---
    @@ -459,12 +638,29 @@ public int compare(Object o1, Object o2) {
     		}
     	}
     
    -	private static class TupleKeySelector implements KeySelector<Tuple2<String, Integer>,
String> {
    -		private static final long serialVersionUID = 1L;
    -
    +	@SuppressWarnings("unchecked")
    +	private static class Tuple3ResultSortComparator implements Comparator<Object>
{
    --- End diff --
    
    duplicate code with `NonKeyedWindowOperatorTest` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message