flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Metzger (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3158) Shading does not remove google guava from flink-dist fat jar
Date Thu, 10 Dec 2015 11:20:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050615#comment-15050615
] 

Robert Metzger commented on FLINK-3158:
---------------------------------------

There is a check in our travis build to ensure guava is not part of the build. However, the
check didn't work.

I think this is a change in the behavior of maven between Maven 3.2 and 3.3.
I've identified the following behavior:

{code}
mvn 3.2.5 (travis)
   1. build ---> correct
   2. build (flink-dist only) --> correct
mvn 3.3.9 (local, the machine used to create releases)
   1. build --> incorrect
   2. build (flink-dist only) --> correct
{code}

I think I have to contact the maven mailing list to understand whats going on.
Guava is not in the dependency tree of "flink-dist".

> Shading does not remove google guava from flink-dist fat jar
> ------------------------------------------------------------
>
>                 Key: FLINK-3158
>                 URL: https://issues.apache.org/jira/browse/FLINK-3158
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 0.10.1
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Blocker
>
> It seems that guava somehow slipped our checks and made it into the flink-dist fat jar
again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message