flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3137) Missing break in OutputEmitter ctor
Date Tue, 08 Dec 2015 01:58:10 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046159#comment-15046159
] 

Ted Yu commented on FLINK-3137:
-------------------------------

I want to point out that current code is prone to bug which might be introduced later.
What if someone adds a break after FORWARD ?

> Missing break in OutputEmitter ctor
> -----------------------------------
>
>                 Key: FLINK-3137
>                 URL: https://issues.apache.org/jira/browse/FLINK-3137
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> Here is related code:
> {code}
>     switch (strategy) {
>     case PARTITION_CUSTOM:
>       extractedKeys = new Object[1];
>     case FORWARD:
>     case PARTITION_HASH:
> {code}
> Looks like a break is missing following assignment to extractedKeys



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message