flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2111) Add "stop" signal to cleanly shutdown streaming jobs
Date Tue, 01 Dec 2015 14:43:11 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033779#comment-15033779
] 

ASF GitHub Bot commented on FLINK-2111:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/750#discussion_r46285468
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
    @@ -402,21 +405,53 @@ public void onComplete(Throwable failure, Object success) throws
Throwable {
     		}
     	}
     
    +	public void stop() {
    +		// sends stop RPC call
    +
    +		final SimpleSlot slot = this.assignedResource;
    +
    +		if (slot != null) {
    +			final ActorGateway gateway = slot.getInstance().getActorGateway();
    +
    +			Future<Object> stopResult = gateway.retry(
    +				new StopTask(attemptId),
    +				NUM_STOP_CALL_TRIES,
    +				timeout,
    +				executionContext);
    +
    +			stopResult.onComplete(new OnComplete<Object>() {
    +				@Override
    +				public void onComplete(Throwable failure, Object success) throws Throwable {
    +					if (failure != null) {
    +						fail(new Exception("Task could not be stopped.", failure));
    +					} else {
    +						TaskOperationResult result = (TaskOperationResult) success;
    +						if (!result.success()) {
    +							LOG.debug("Stopping task call did not find task. Probably akka message call race.");
    --- End diff --
    
    Again sticking to antiquated traditions is imho not a good option if one can improve it.
Including the change of `cancel's` `onComplete` would be ok for me here. But in general, orthogonal
changes should be included in a separate PR.


> Add "stop" signal to cleanly shutdown streaming jobs
> ----------------------------------------------------
>
>                 Key: FLINK-2111
>                 URL: https://issues.apache.org/jira/browse/FLINK-2111
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime, JobManager, Local Runtime, Streaming, TaskManager,
Webfrontend
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
>
> Currently, streaming jobs can only be stopped using "cancel" command, what is a "hard"
stop with no clean shutdown.
> The new introduced "stop" signal, will only affect streaming source tasks such that the
sources can stop emitting data and shutdown cleanly, resulting in a clean shutdown of the
whole streaming job.
> This feature is a pre-requirment for https://issues.apache.org/jira/browse/FLINK-1929



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message