flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3118] [Gelly] Consider ResultTypeQuerya...
Date Mon, 21 Dec 2015 15:53:01 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1471#discussion_r48158308
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
---
    @@ -340,6 +340,15 @@ protected TypeExtractor() {
     		}
     		return ti;
     	}
    +
    +	@SuppressWarnings("unchecked")
    +	public static <OUT> TypeInformation<OUT> createTypeInfo(Class<?> baseClass,
Class<?> clazz, int returnParamPos, Object instance) {
    --- End diff --
    
    I would maybe move the `instance` parameter to the front of the parameter list. Then it's
similar to `getUnaryOperatorReturnType`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message