flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3023][web-dashboard] Display version an...
Date Wed, 09 Dec 2015 10:29:45 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-runtime-web/web-dashboard/app/partials/overview.jade ---
    @@ -22,6 +22,12 @@ nav.navbar.navbar-default.navbar-fixed-top.navbar-main
         | Overview
    +  .navbar-info.last.first
    +    | Version: {{overview['flink-version']}}
    +  .navbar-info.last.first(ng-if="overview['flink-commit']")
    +    | Commit: {{overview['flink-commit']}}
    --- End diff --
    Will this print "unknown" as commit ID (because the JSON field is not present) or will
it be skipped?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message