flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3074] Add config option to start YARN A...
Date Wed, 09 Dec 2015 10:25:37 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala
    @@ -120,18 +125,76 @@ abstract class ApplicationMasterBase {
             config.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, 0)
    -      val (actorSystem, jmActor, archiveActor, webMonitor) =
    +      // we try to start the JobManager actor system using the port definition
    +      // from the config.
    +      // first, we check if the port is available by opening a socket
    +      // if the actor system fails to start on the port, we try further
    +      val amPortRange: String = config.getString(ConfigConstants.YARN_APPLICATION_MASTER_PORT,
    +      val portsIterator = NetUtils.getPortRangeFromString(amPortRange)
    +      // method to start the actor system.
    +      def startActorSystem(portsIterator: java.util.Iterator[Integer]): // return type
-> next line
    --- End diff --
    When you do line breaks in the method header you usually put each parameter in a new line
with double indentation and the return type with the colon in a new line with single indentation.
    def foo(
        foo: Bar
        bar: Foo)
      : Foobar = {

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message