flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3102] Allow reading from multiple topic...
Date Mon, 07 Dec 2015 16:01:53 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1437#discussion_r46837656
  
    --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Fetcher.java
---
    @@ -61,15 +53,15 @@
     	 *     }
     	 * }
     	 * }</pre>
    -	 * 
    +	 *
    +	 * @param <T> The type of elements produced by the fetcher and emitted to the
source context.
     	 * @param sourceContext The source context to emit elements to.
     	 * @param valueDeserializer The deserializer to decode the raw values with.
    -	 * @param lastOffsets The array into which to store the offsets for which elements are
emitted (operator state)
    -	 * 
    -	 * @param <T> The type of elements produced by the fetcher and emitted to the
source context.
    +	 * @param lastOffsets The map into which to store the offsets for which elements are
emitted (operator state)
    +*
    --- End diff --
    
    Fixed the `*`.
    The java standard library is putting generic parameters first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message