flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3074] Add config option to start YARN A...
Date Mon, 07 Dec 2015 13:25:15 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1416#discussion_r46819698
  
    --- Diff: flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala
---
    @@ -120,16 +122,73 @@ abstract class ApplicationMasterBase {
             config.setInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, 0);
           }
     
    -      val (actorSystem, jmActor, archiveActor, webMonitor) =
    -        JobManager.startActorSystemAndJobManagerActors(
    -          config,
    -          JobManagerMode.CLUSTER,
    -          streamingMode,
    -          ownHostname,
    -          0,
    -          getJobManagerClass,
    -          getArchivistClass
    -        )
    +      // we try to start the JobManager actor system using the port definition
    +      // from the config.
    +      // first, we check if the port is available by opening a socket
    +      // if the actor system fails to start on the port, we try further
    +      val amPortRange: String = config.getString(ConfigConstants.YARN_APPLICATION_MASTER_PORT,
    +        ConfigConstants.DEFAULT_YARN_APPLICATION_MASTER_PORT)
    +      val portsSet = NetUtils.getPortRangeFromString(amPortRange)
    +
    +      // Try to start the actor system with the given set of ports:
    +      var startActorResultOption: Option[(ActorSystem, ActorRef, ActorRef, Option[WebMonitor])]
=
    +        None
    +
    +      while (startActorResultOption.isEmpty && portsSet.size() > 0) {
    +        if(portsSet == null) {
    +          throw new RuntimeException(s"Unable to allocate port for ApplicationMaster
in " +
    +            s"specified port range: $amPortRange. No more ports available")
    +        }
    --- End diff --
    
    maybe linebreak after closing curly bracket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message