flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3073] Replace Streaming Mode by Memory ...
Date Thu, 03 Dec 2015 14:41:15 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1433#discussion_r46558419
  
    --- Diff: flink-dist/src/main/flink-bin/bin/taskmanager.sh ---
    @@ -63,7 +57,7 @@ if [[ $STARTSTOP == "start" ]]; then
             #
             TM_MAX_OFFHEAP_SIZE="8388607T"
     
    -        if [[ "${STREAMINGMODE}" == "batch" ]] && useOffHeapMemory; then
    +        if [[ "${FLINK_TM_MEM_ALLOC}" == "eager" ]] && useOffHeapMemory; then
    --- End diff --
    
    For the off-heap memory case, the JVM heap memory should be reduced regardless of eager
or lazy memory allocation. I think this can be changed to
    
    ```bash
    if useOffHeapMemory; then
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message